Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blueprint: GLB hybrid NEG internal #1150

Merged
merged 6 commits into from
Mar 2, 2023
Merged

Blueprint: GLB hybrid NEG internal #1150

merged 6 commits into from
Mar 2, 2023

Conversation

LucaPrete
Copy link
Member

No description provided.

@LucaPrete LucaPrete force-pushed the bp-glb-hybrid-neg-internal branch from 217293f to dd6edd8 Compare February 11, 2023 15:33
@ludoo ludoo changed the title Blueprint: XGLB hybrid NEG internal Blueprint: GLB hybrid NEG internal Feb 11, 2023
ludoo
ludoo reviewed Feb 25, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luca, can you convert tests to the new style? @juliocc can provide guidance while the contributing guide is not up to date.

@LucaPrete LucaPrete requested a review from ludoo February 27, 2023 13:34
ludoo
ludoo requested changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, dropped a few comments then it looks as it's good to go

blueprints/networking/glb-hybrid-neg-internal/README.md Outdated Show resolved Hide resolved
blueprints/networking/glb-hybrid-neg-internal/variables.tf Outdated Show resolved Hide resolved
blueprints/networking/glb-hybrid-neg-internal/variables.tf Outdated Show resolved Hide resolved
blueprints/networking/glb-hybrid-neg-internal/variables.tf Outdated Show resolved Hide resolved
blueprints/networking/glb-hybrid-neg-internal/landing-hub.tf Outdated Show resolved Hide resolved
blueprints/networking/glb-hybrid-neg-internal/landing-hub.tf Outdated Show resolved Hide resolved
blueprints/networking/glb-hybrid-neg-internal/spoke.tf Show resolved Hide resolved
@LucaPrete LucaPrete force-pushed the bp-glb-hybrid-neg-internal branch from 1e879af to 25196fa Compare March 1, 2023 20:36
@LucaPrete
Copy link
Member Author

@ludoo @juliocc it seems now this is failing for external causes. Can anybody please try to re-run the job?

@ludoo
Copy link
Collaborator

ludoo commented Mar 1, 2023

@ludoo @juliocc it seems now this is failing for external causes. Can anybody please try to re-run the job?

Done

@LucaPrete LucaPrete merged commit a5fd32e into master Mar 2, 2023
@LucaPrete LucaPrete deleted the bp-glb-hybrid-neg-internal branch March 2, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

@sruffilli sruffilli Awaiting requested review from sruffilli

@simonebruzzechesse simonebruzzechesse Awaiting requested review from simonebruzzechesse

Assignees
No one assigned
Labels
on:blueprints on:documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucaPrete @ludoo